Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eap): Add mutations topic to Snuba #6322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(eap): Add mutations topic to Snuba #6322

wants to merge 1 commit into from

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Sep 18, 2024 •
edited
Loading

Doing this separately so we can roll it out independently of the actual consumer: #6216

This will be rolled out after the schema is published getsentry/sentry-kafka-schemas#333

@ayirr7 ayirr7 requested a review from a team as a code owner September 18, 2024 19:18
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2557 1 2556 4
View the top 1 failed tests by shortest run time 
tests.utils.streams.test_topics test_valid_topics
Stack Traces | 0.141s run time 
Traceback (most recent call last):
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 79, in get_topic
    with open(topic_path) as f:
         ^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '.../local/lib/python3.11.../sentry_kafka_schemas/topics/snuba-eap-mutations.yaml'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../utils/streams/test_topics.py", line 10, in test_valid_topics
    sentry_kafka_schemas.get_topic(
  File ".../local/lib/python3.11....../site-packages/sentry_kafka_schemas/sentry_kafka_schemas.py", line 82, in get_topic
    raise SchemaNotFound
sentry_kafka_schemas.sentry_kafka_schemas.SchemaNotFound

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayirr7 @untitaker